feat: add position write #4795
Merged
feat: add position write #4795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Jun 24, 2024
| /// PositionWriter will call this API when: | ||
| /// | ||
| /// - All the data has been written to the buffer and we can perform the upload at once. | ||
| fn write_once(&self, body: Buffer) -> impl Future<Output = Result<()>> + MaybeSend; |
There was a problem hiding this comment.
I feel like PositionWrite don't need write_once anymore since it should be exactly the same with write_all_at(0, buf)
| fn write_all_at( | ||
| &self, | ||
| offset: u64, | ||
| body: Buffer, |
There was a problem hiding this comment.
Please use buf instead of body in API.
| ) -> impl Future<Output = Result<()>> + MaybeSend; | ||
| } | ||
|
|
||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Those code should not be dead_code since we have exposed them.
| } | ||
|
|
||
| async fn abort(&mut self) -> Result<()> { | ||
| Ok(()) |
There was a problem hiding this comment.
We might consider adding a truncate API to discard existing written data. Let's table this feature for future discussion. Would you like to create an issue for this?
There was a problem hiding this comment.
I created a new issue for this.
There was a problem hiding this comment.
@Xuanwo Have any problem yet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part #4526