Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/services/onedrive): remove @odata.count for onedrive list op #4803

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

imWildCat
Copy link
Contributor

This @odata.count does not seem to exist before in their official docs...

Recently I found they don't return this field anymore so all list op would raise errors.

I'm going to remove it.

In this repo, this field does not exist for all the time: https://github.com/sreeise/graph-rs-sdk/blob/afda1dcfbf5d491e56c6753152a1ce7e1c97fb44/test_files/drive_ep/drive_root_child.json#L4

@imWildCat
Copy link
Contributor Author

for the record, I verified this change locally on my branch

image

end to end

I don't think a local run of the behavior test is needed because this PR is deleting an unused field

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 25fde06 into apache:main Jun 25, 2024
73 checks passed
@imWildCat
Copy link
Contributor Author

Thanks!

thanks for the quick review! 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants