Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integration/object_store): Fix metakey requested is incomplete #4844

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 2, 2024

object_store uses more metadata than requrested, let's make sure they are aligned.

integrations/object_store/src/store.rs Outdated Show resolved Hide resolved
integrations/object_store/src/store.rs Outdated Show resolved Hide resolved
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 2, 2024

Hi, @George-Miao, all comments have been addressed. PTAL.

Copy link
Contributor

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo Xuanwo merged commit c9c2bb2 into main Jul 2, 2024
28 checks passed
@Xuanwo Xuanwo deleted the fix-object-sotre-meta branch July 2, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants