Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integration/object_store): Avoid calling API inside debug #4846

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 2, 2024

Calling op.info() inside Debug might introduce dead lock for logging.

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Contributor

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo Xuanwo merged commit e58e616 into main Jul 2, 2024
29 checks passed
@Xuanwo Xuanwo deleted the fix-object-store-debug branch July 2, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants