Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add object versioning for OSS #4870

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

Lzzzzzt
Copy link
Contributor

@Lzzzzzt Lzzzzzt commented Jul 8, 2024

This pull request add support of object versioning for OSS

Part of #2611

Basically, done the following task

  • change the args of oss_head_object and oss_head_object_request to receive the version info
  • add versionId param of the url sent (get, head, del) to the oss server
  • change the reader in types/read/reader to let reader send head req with the same version info of get req

@Lzzzzzt Lzzzzzt requested a review from Xuanwo as a code owner July 8, 2024 09:56
@github-actions github-actions bot requested a review from oowl July 8, 2024 09:56
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
@Xuanwo Xuanwo changed the title Feat(core): Add object versioning for OSS feat(core): Add object versioning for OSS Jul 8, 2024
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

core/src/raw/http_util/header.rs Outdated Show resolved Hide resolved
core/src/services/oss/backend.rs Show resolved Hide resolved
core/src/services/oss/core.rs Outdated Show resolved Hide resolved
core/src/types/read/reader.rs Outdated Show resolved Hide resolved
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@Xuanwo Xuanwo merged commit e6ccc8f into apache:main Jul 8, 2024
218 checks passed
@Lzzzzzt Lzzzzzt deleted the object-versioning-oss branch August 28, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants