Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layers/mime-guess): add a layer that can automatically set Content-Type based on the extension in the path. #4912

Merged
merged 7 commits into from
Jul 19, 2024

Conversation

czy-29
Copy link
Contributor

@czy-29 czy-29 commented Jul 18, 2024

Which issue does this PR close?

Closes #4902 .

What changes are included in this PR?

Added a Feature Flag: layers-mime-guess
And a Layer type: MimeGuessLayer

…ent-Type` based on the extension in the path.
core/src/layers/mime_guess.rs Outdated Show resolved Hide resolved
core/src/layers/mime_guess.rs Outdated Show resolved Hide resolved
core/src/layers/mime_guess.rs Show resolved Hide resolved
core/src/layers/mime_guess.rs Show resolved Hide resolved
core/src/layers/mime_guess.rs Outdated Show resolved Hide resolved
core/src/layers/mime_guess.rs Outdated Show resolved Hide resolved
core/src/layers/mime_guess.rs Outdated Show resolved Hide resolved
@czy-29
Copy link
Contributor Author

czy-29 commented Jul 19, 2024

Thanks for the review. I will go and make the modifications mentioned.

@czy-29
Copy link
Contributor Author

czy-29 commented Jul 19, 2024

All modifications have been completed! I feel like we can merge now. Or you can also take a look and see if there are any other issues?

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Welcome to become opendal contributor!

@Xuanwo Xuanwo merged commit d9d4279 into apache:main Jul 19, 2024
219 checks passed
@czy-29 czy-29 deleted the feat-layers-mime-guess branch July 20, 2024 03:17
@czy-29
Copy link
Contributor Author

czy-29 commented Jul 20, 2024

Oops... I forgot to update the Layers chapter in the README: https://github.com/apache/opendal/blob/main/core/README.md#layers

@Xuanwo
Copy link
Member

Xuanwo commented Jul 20, 2024

Oops... I forgot to update the Layers chapter in the README: https://github.com/apache/opendal/blob/main/core/README.md#layers

Welcome to submit a new PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants