feat(core)!: Make config data object #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
tisonkun
force-pushed
the
make-config-data-object
branch
from
d540734
to
580bd5d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Xuanwo
reviewed
Jul 20, 2024
| type Config: DeserializeOwned; | ||
|
|
||
| /// Construct a builder from given config. | ||
| fn from_config(config: Self::Config) -> Self; |
There was a problem hiding this comment.
I want to return Result<Self> in from_config and from_map to avoid panic during the build process. Would you like to help implementing it in this PR or start a new PR for this? Or I can continue the work after this PR.
There was a problem hiding this comment.
Let's make further non-blocker change in a follow-up PR. I can do it, but not in this one unless it's necessary.
Xuanwo
changed the title
|
@Xuanwo Actually this is not a breaking change .. What parts are breaking? |
Builder is a public trait. All users implement this API will fail to compile. Adding a new associated type and required function are breaking changes. |
Xuanwo
approved these changes
Jul 20, 2024
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This closes #3240.
What changes are included in this PR?
See commits message.
Are there any user-facing changes?
All builder has an associated config data object type now.