Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): Fix comment for into_futures_async_write #4928

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 26, 2024

Which issue does this PR close?

Closes #4926.

Rationale for this change

The comment is wrong. I'm guessing I copied it wrong from futures or std.

What changes are included in this PR?

Fix the comment.

Are there any user-facing changes?

No behavior changed. Just correct the comment.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit fff8c74 into main Jul 26, 2024
254 of 255 checks passed
@Xuanwo Xuanwo deleted the fix-comment branch July 26, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: FuturesAsyncWriter does not properly close/shutdown the writer
3 participants