Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(o): Add cargo-o layout #4934

Merged
merged 1 commit into from
Jul 28, 2024
Merged

feat(o): Add cargo-o layout #4934

merged 1 commit into from
Jul 28, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 28, 2024

Which issue does this PR close?

Part of #4933

Rationale for this change

What changes are included in this PR?

Add cargo o support.

Are there any user-facing changes?

Signed-off-by: Xuanwo <github@xuanwo.io>
Comment on lines +19 to +20
description = "Apache OpenDAL™ Development Tools"
name = "odev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe publish = false

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add this later if needed. I'm fine to release it 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be tight with this repo and have a lot of context/environment logics. Let's avoid release thing like this. Plus the name is not fully reasonable as a published crate.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

@Xuanwo Xuanwo merged commit 22214de into main Jul 28, 2024
12 checks passed
@Xuanwo Xuanwo deleted the cargo-o branch July 28, 2024 12:24
ho-229 pushed a commit to ho-229/incubator-opendal that referenced this pull request Aug 6, 2024
Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants