refactor(core): Use kv based context to avoid allocations #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
PsiACE
approved these changes
Aug 9, 2024
evenyag
reviewed
Aug 14, 2024
Comment on lines
+198
to
+204
| context.iter().enumerate().map(|(i, (k, v))| { | ||
| if i > 0 { | ||
| format!(" {}={}", k, v) | ||
| } else { | ||
| format!("{}={}", k, v) | ||
| } | ||
| }).collect::<String>() |
There was a problem hiding this comment.
Looks like we need more allocations than before. One string for each key-value pair and the collected string.
There was a problem hiding this comment.
Perhaps we could use a single string with calculated capacity to ensure only one allocation occurs. Or something better, we can implement a new type LoggingContext(&[(&str, &str)]) and implement Display for it.
Would you like to help implement it?
There was a problem hiding this comment.
A new type should be better. Should we expose this new type to users?
Would you like to help implement it?
Sure.
There was a problem hiding this comment.
Should we expose this new type to users?
I'm guessing we don't need to, just wrap it while calling log!() should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Followup of #4961
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?