Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations/spring): add AutoConfiguration class for Spring Mvc and Webflux #5019

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

shoothzj
Copy link
Member

Main Issue #5015.

@shoothzj shoothzj force-pushed the add-autoconfiguration branch 2 times, most recently from 0e800af to 7c68027 Compare August 19, 2024 08:21
… and Webflux

Signed-off-by: ZhangJian He <shoothzj@gmail.com>
@Xuanwo
Copy link
Member

Xuanwo commented Aug 19, 2024

Inviting @tisonkun to take a look.

Comment on lines +44 to +48
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems no tests to guard that the configuration work as expected.

@shoothzj what is the plan on this point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisonkun I plan to add tests in the future to guard the bean load successfully.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep moving

@tisonkun tisonkun merged commit d46cbc0 into apache:main Aug 19, 2024
29 checks passed
@shoothzj shoothzj deleted the add-autoconfiguration branch August 20, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants