-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations/spring): add AutoConfiguration class for Spring Mvc and Webflux #5019
Conversation
...eactive/src/main/java/org/apache/opendal/spring/config/OpenDALReactiveAutoConfiguration.java
Show resolved
Hide resolved
f263ccc
to
2889683
Compare
...ng-boot-starter/src/main/java/org/apache/opendal/spring/config/OpenDALAutoConfiguration.java
Outdated
Show resolved
Hide resolved
integrations/spring/opendal-spring/src/main/java/org/apache/opendal/spring/core/OpenDAL.java
Outdated
Show resolved
Hide resolved
0e800af
to
7c68027
Compare
… and Webflux Signed-off-by: ZhangJian He <shoothzj@gmail.com>
7c68027
to
63372fe
Compare
Inviting @tisonkun to take a look. |
<dependency> | ||
<groupId>org.springframework.boot</groupId> | ||
<artifactId>spring-boot-starter-test</artifactId> | ||
<scope>test</scope> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems no tests to guard that the configuration work as expected.
@shoothzj what is the plan on this point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tisonkun I plan to add tests in the future to guard the bean load successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep moving
Main Issue #5015.