Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layers/prometheus-client): remove duplicated increment_request_total of write operation #5023

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Aug 20, 2024

Which issue does this PR close?

No

Rationale for this change

Repeatedly record the requests_total of the write operation.

What changes are included in this PR?

  • Remove duplicated increment_request_total metric of write operation.
  • Update the example of prometheus-client layer doc

Are there any user-facing changes?

No

@koushiro koushiro requested a review from Xuanwo as a code owner August 20, 2024 06:17
@koushiro
Copy link
Contributor Author

The main fix is d4c9262

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit a7e1d00 into apache:main Aug 20, 2024
223 of 224 checks passed
@koushiro koushiro deleted the fix-promethues-client-layer branch August 20, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants