feat(core): expose configs always #5034
Conversation
Signed-off-by: tison <wander4096@gmail.com>
core/src/services/config.rs
Outdated
| /// Sets the time to live of the cache. | ||
| /// | ||
| /// Refer to [`mini-moka::sync::CacheBuilder::time_to_live`](https://docs.rs/mini-moka/latest/mini_moka/sync/struct.CacheBuilder.html#method.time_to_live) | ||
| pub time_to_live: Option<Duration>, |
There was a problem hiding this comment.
Duration's default serde is weird (things like { "secs": 1, "nanos": 0 }.
It's better to use humantime-serde but that should be a follow up and breaking change.
There was a problem hiding this comment.
I'm considering using an int directly instead of exposing Duration. What do you think?
There was a problem hiding this comment.
Somehow reasonable. In milliseconds precison?
I move them to Each struct is tidy and no more extension can be added. So split to many files ( |
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
expose-configs-always
branch
from
01cc076
to
96ed78f
Compare
Signed-off-by: Xuanwo <github@xuanwo.io>
|
cc @tisonkun, please take a look. I prefer to have them in separate files for better readability and easier future code generation. |
|
@Xuanwo let's give an approval and move forward. |
Resolve #5033
This demonstrates what will happen. @Xuanwo let's see if it's a good idea.