Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bindings/go): bump ffi and sys version #5055

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

shoothzj
Copy link
Member

Main Issue #5051

Rationale for this change

This is part of #5051. I prefer to bump the version first, followed by adding Golang Windows CI to continuously monitor this feature.

Signed-off-by: ZhangJian He <shoothzj@gmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo requested a review from yuchanns August 26, 2024 09:23
@Xuanwo
Copy link
Member

Xuanwo commented Aug 26, 2024

Inviting @yuchanns for another review.

Copy link
Member

@yuchanns yuchanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green. Thanks!

@Xuanwo Xuanwo merged commit 1cd5199 into apache:main Aug 26, 2024
30 checks passed
@shoothzj shoothzj deleted the bump-go-bindings branch August 26, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants