Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): TimeoutLayer now needs enable tokio time #5057

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 26, 2024

Which issue does this PR close?

Follow up of #5056

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 26, 2024

cc @George-Miao for a review, thanks!

Copy link
Contributor

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo Xuanwo merged commit 74b4b0a into main Aug 26, 2024
247 of 248 checks passed
@Xuanwo Xuanwo deleted the fix-backon branch August 26, 2024 13:20
@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 26, 2024

LGTM

As long as we fix it quickly enough, no one will know what happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants