Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(services/rocksdb): fix misuse rocksdb prefix iterator #5059

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

meteorgan
Copy link
Contributor

@meteorgan meteorgan commented Aug 27, 2024

Which issue does this PR close?

None

Rationale for this change

According to https://github.com/facebook/rocksdb/wiki/Prefix-Seek#transition-to-the-new-usage. rocksdb will return keys equal or larger than the prefix

What changes are included in this PR?

Are there any user-facing changes?

@meteorgan meteorgan marked this pull request as ready for review August 27, 2024 02:36
@meteorgan meteorgan requested a review from Xuanwo as a code owner August 27, 2024 02:36
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 89074f0 into apache:main Aug 27, 2024
82 checks passed
@meteorgan meteorgan deleted the fix_rocksdb_prefix_iterator branch September 6, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants