refactor(layers/prometheus): rewrite prometheus layer based on observe mod #5069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koushiro
force-pushed
the
rewrite-prometheus-layer
branch
from
ce34e6a
to
b7ea2b9
Compare
Xuanwo
reviewed
Aug 29, 2024
Xuanwo
reviewed
Aug 29, 2024
core/src/layers/prometheus.rs
Outdated
| Err(err) | ||
| } | ||
| if error { | ||
| names.push(observe::LABEL_ERROR); |
There was a problem hiding this comment.
Is the order significant? Should we place path before error?
There was a problem hiding this comment.
The order of path and error is not important, what is important is that the order of label names and label values should correspond, otherwise there will be problems
| self.stats.increment_errors_total(self.op, err.kind()); | ||
| Err(err) | ||
| } | ||
| if path_label_level > 0 { |
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
related PR: #5064
Rationale for this change
What changes are included in this PR?
rewrite
PrometheusLayerbased onobservemodAre there any user-facing changes?
API breaking change