Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): add lakefs support #5086

Merged
merged 12 commits into from
Sep 2, 2024
Merged

feat(services): add lakefs support #5086

merged 12 commits into from
Sep 2, 2024

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Sep 1, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Add lakefs service. Refer to https://lakefs.io/

What changes are included in this PR?

Are there any user-facing changes?

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.23.6 to 1.24.3.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.23.6...v1.24.3)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@Xuanwo
Copy link
Member

Xuanwo commented Sep 1, 2024

Thank you very much for your PR! Before we start reviewing it, could you please fix the code formatting and run a Clippy check? These issues can be resolved by:

cargo fmt
cargo clippy --features=services-lakefs

@liugddx liugddx marked this pull request as ready for review September 1, 2024 12:19
.github/workflows/ci_check.yml Outdated Show resolved Hide resolved
core/src/services/lakefs/backend.rs Outdated Show resolved Hide resolved
core/src/services/lakefs/backend.rs Outdated Show resolved Hide resolved
core/src/services/lakefs/backend.rs Outdated Show resolved Hide resolved
///
/// This is required.
pub repository_id: Option<String>,
/// Name of the branch or a commit ID. Default is main.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be ref instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be ref instead?

ref is a keyword

core/src/services/lakefs/backend.rs Outdated Show resolved Hide resolved
core/src/services/lakefs/core.rs Outdated Show resolved Hide resolved
core/src/services/lakefs/core.rs Outdated Show resolved Hide resolved
core/src/services/lakefs/core.rs Show resolved Hide resolved
core/src/services/lakefs/mod.rs Outdated Show resolved Hide resolved
core/src/services/mod.rs Outdated Show resolved Hide resolved
@liugddx liugddx requested a review from Xuanwo September 2, 2024 01:47
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 721b0e8 into apache:main Sep 2, 2024
229 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants