refactor: make parse http error code public #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. now all http related service use public parse_http_error_code function 2. update gitignore Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
|
Please resolve conflicts before reviewing. |
Xuanwo
changed the title
|
I'm a bit worried about this refactor: because different services could have a different meanings for the same status code. |
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
We can wrap this up for further configurations into a trait, and make the function the default implementation. For now, those functions are literally the same. The only difference between them is their visibility. |
|
I don't like the idea to extract a trait for such simple thing... |
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Makes sense to me. Service can implement their own error kind parser if needed. |
Xuanwo
reviewed
Aug 11, 2022
rename parse_http_error_code to parse_error_status_code Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
function
Signed-off-by: ClSlaid cailue@bupt.edu.cn
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/