Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(*): remove unneeded async and result on parse_error #5131

Merged
merged 2 commits into from
Sep 23, 2024
Merged

refactor(*): remove unneeded async and result on parse_error #5131

merged 2 commits into from
Sep 23, 2024

Conversation

tsfotis
Copy link
Contributor

@tsfotis tsfotis commented Sep 20, 2024

Rationale for this change

  • No need for parse_error to be async
  • No need to return a Result

What changes are included in this PR?

removes unneeded async and Result from parse_error()
improve encapsulation of parse_error

Are there any user-facing changes?

No

@tsfotis
Copy link
Contributor Author

tsfotis commented Sep 20, 2024 •
edited
Loading

@Xuanwo this is the continuation from #5128.

Turns out it was more changes than I thought, sorry for any rebase headaches.
Review and merge when the time is right 👍 .

Also added the unused_async clippy lint at 50956e9, although for some reason it didn't warn about async parse_error function.

@tsfotis tsfotis marked this pull request as ready for review September 20, 2024 21:36
Xuanwo
Xuanwo approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for working on this!

@Xuanwo Xuanwo merged commit 3947f6d into apache:main Sep 23, 2024
231 checks passed
@tsfotis tsfotis deleted the refactor/remove-unneeded-async branch September 23, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsfotis @Xuanwo