build(bindings/c): replace the build system with CMake #5182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
approved these changes
Oct 15, 2024
tisonkun
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Perhaps we can adopt Kvrocks' x.py flavor here now 🐶
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3516.
Rationale for this change
As state in #3516, CMake works well for large project than makefile.
Also in CMake we can fetch the gtest from web and use it simply than depending on a system-level gtest.
What changes are included in this PR?
examples/basic.c.Note that Valgrind part is removed and replaced by AddressSanitizer.
Are there any user-facing changes?
Users of C binding should be aware of this change, and should build from CMake instead of Makefile from now on.
cc @tisonkun