Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bin/*): remove useless deps #5212

Merged
merged 1 commit into from
Oct 20, 2024
Merged

chore(bin/*): remove useless deps #5212

merged 1 commit into from
Oct 20, 2024

Conversation

koushiro
Copy link
Member

Which issue does this PR close?

No

Rationale for this change

What changes are included in this PR?

Remove useless deps of bin/oay, bin/ofs and bin/oli

➜  bin git:(remove-useless-deps) cargo machete
Analyzing dependencies of crates in this directory...
cargo-machete didn't find any unused dependencies in this directory. Good job!
Done!

Are there any user-facing changes?

No

@koushiro koushiro changed the title chrore(bin/*): remove useless deps chore(bin/*): remove useless deps Oct 20, 2024
Xuanwo
Xuanwo approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciated. Thank you @koushiro!

@Xuanwo Xuanwo merged commit 6e0508d into apache:main Oct 20, 2024
18 checks passed
@koushiro koushiro deleted the remove-useless-deps branch October 20, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koushiro @Xuanwo