Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrations/compat): Capability has different fields #5236

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 24, 2024

Which issue does this PR close?

Closes #5235

Rationale for this change

opendal v0.50's Capability has a new field called write_with_if_none_match, we can't transmute it.

What changes are included in this PR?

Add convert between Capability.

Are there any user-facing changes?

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 24, 2024

Thank you @dqhl76 for the quick review!

@Xuanwo Xuanwo merged commit 0ef4fea into main Oct 24, 2024
30 checks passed
@Xuanwo Xuanwo deleted the add-tests branch October 24, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: opendal compat doesn't work as expected
2 participants