Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core/raw): align info method of kv::Adapter and typed_kv::Adapter #5259

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

koushiro
Copy link
Member

Which issue does this PR close?

No

Rationale for this change

The metadata method of kv::Adapter and info method of typed_kv::Adapter is misaligned.

What changes are included in this PR?

  • rename metadata method of kv::Adapter: fn metadata(&self) -> Metadata; => fn info(&self) -> Info;
  • rename Metadata type of kv module: pub struct Metadata {...} => pub struct Info {...}
  • remove impl From<kv::Metadata> for AccessorInfo { ... }

Are there any user-facing changes?

  • rename kv::Adapter::metadata() => kv::Adapter::info()
  • rename kv::Metadata => kv::Info
  • remove impl From<kv::Metadata> for AccessorInfo { ... }

@koushiro koushiro requested a review from Xuanwo as a code owner October 31, 2024 11:53
@koushiro koushiro changed the title chore(core/raw): align info method of kv::Adapter and typed_kv::Adapter chore(core/raw): align info method of kv::Adapter and typed_kv::Adapter Oct 31, 2024
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @koushiro for polishing our code!

@Xuanwo
Copy link
Member

Xuanwo commented Nov 5, 2024

Hi, @koushiro, there are some conflicts preventing us from merging this PR. Could you take a look?

@Xuanwo Xuanwo merged commit f93c619 into apache:main Nov 5, 2024
236 checks passed
@koushiro koushiro deleted the align-adapter-api branch November 5, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants