Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run object_store tests in CI #5268

Merged

Conversation

jorgehermo9
Copy link
Contributor

@jorgehermo9 jorgehermo9 commented Nov 1, 2024

Closes #5237

Based on other integration CI:

//! .into_iter()
//! .collect(),
//! ).unwrap();
//! let builder = S3::default()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that it is an outdated doc test. Change inspired from https://docs.rs/opendal/latest/opendal/services/struct.S3.html#basic-setup

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jorgehermo9 for implementing this!

@Xuanwo Xuanwo merged commit 8e142c8 into apache:main Nov 1, 2024
30 checks passed
@jorgehermo9 jorgehermo9 deleted the feature/include-object-store-test-in-ci branch November 1, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new feature: Running object_store tests in CI
2 participants