-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove metakey concept #5319
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
CodSpeed Performance ReportMerging #5319 will degrade performances by 16.59%Comparing Summary
Benchmarks breakdown
|
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Feel the same with you. It can be a bit distracting. For those who aren't familiar with what it means, it might cause unnecessary concern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which issue does this PR close?
Part of #5314
Rationale for this change
To make
Lister
behavior more predictable.What changes are included in this PR?
Remove the metakey concept.
Are there any user-facing changes?