Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove metakey concept #5319

Merged
merged 3 commits into from
Nov 14, 2024
Merged

refactor: Remove metakey concept #5319

merged 3 commits into from
Nov 14, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 13, 2024

Which issue does this PR close?

Part of #5314

Rationale for this change

To make Lister behavior more predictable.

What changes are included in this PR?

Remove the metakey concept.

Are there any user-facing changes?

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #5319 will degrade performances by 16.59%

Comparing remove-metakey (11ef737) with main (297bbf9)

Summary

⚡ 4 improvements
❌ 10 regressions
✅ 59 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main remove-metakey Change
bytes buf 256 KiB * 32 advance 435 ns 493.3 ns -11.82%
bytes buf 256 KiB * 4 advance 435 ns 493.3 ns -11.82%
bytes buf 4.00 MiB * 32 advance 435 ns 493.3 ns -11.82%
bytes buf 4.00 MiB * 4 advance 435 ns 493.3 ns -11.82%
256 KiB * 1000k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 1000k truncate 245.8 ns 275 ns -10.61%
256 KiB * 100k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 100k truncate 245.8 ns 275 ns -10.61%
256 KiB * 10k chunk 212.8 ns 183.6 ns +15.89%
256 KiB * 10k truncate 245.8 ns 275 ns -10.61%
256 KiB * 1k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 1k truncate 245.8 ns 275 ns -10.61%
concurrent 16 299.8 µs 359.5 µs -16.59%
concurrent 8 319.2 µs 363.9 µs -12.3%

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 13, 2024

Merging #5319 will degrade performances by 15.89%

cc @dqhl76, I'm considering disabling tests for those cases or simply refactoring them. They've never been reported correctly...

Any ideas?

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@dqhl76
Copy link
Member

dqhl76 commented Nov 13, 2024

Any ideas?

Feel the same with you. It can be a bit distracting. For those who aren't familiar with what it means, it might cause unnecessary concern.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo Xuanwo merged commit cd2fc9f into main Nov 14, 2024
273 of 274 checks passed
@Xuanwo Xuanwo deleted the remove-metakey branch November 14, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants