Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement integration tests for gcs #532

Merged
merged 5 commits into from
Aug 16, 2022
Merged

feat: Implement integration tests for gcs #532

merged 5 commits into from
Aug 16, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 16, 2022

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

feat: Implement integration tests for gcs

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 16, 2022

Cc @ClSlaid for reviewing

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from ClSlaid August 16, 2022 09:31
.env.example Show resolved Hide resolved
.github/workflows/service_test_gcs.yml Show resolved Hide resolved
1. fix percent encoder for GCS
2. allow 404 in GCS::backend::<Accessor>::delete()

Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
@ClSlaid
Copy link
Contributor

ClSlaid commented Aug 16, 2022

/cc @Xuanwo PTAL

Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 16, 2022

Great work!

@Xuanwo Xuanwo merged commit bfbb24e into main Aug 16, 2022
@Xuanwo Xuanwo deleted the behavior-test-gcs branch August 16, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants