Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Polish docs for write with if not exists #5320

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 14, 2024

Which issue does this PR close?

None

Rationale for this change

Improve docs

What changes are included in this PR?

Make the behavior of different options more clear.

Are there any user-facing changes?

No, just docs change.

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #5320 will degrade performances by 18.88%

Comparing polish-if-not-exsts (98528e9) with main (cd2fc9f)

Summary

❌ 8 regressions
✅ 65 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main polish-if-not-exsts Change
buffer 256 KiB * 32 chunk 154.4 ns 183.6 ns -15.89%
buffer 256 KiB * 4 chunk 125.3 ns 154.4 ns -18.88%
buffer 4.00 MiB * 32 chunk 125.3 ns 154.4 ns -18.88%
buffer 4.00 MiB * 4 chunk 125.3 ns 154.4 ns -18.88%
256 KiB * 1000k truncate 245.8 ns 275 ns -10.61%
256 KiB * 100k truncate 245.8 ns 275 ns -10.61%
256 KiB * 10k truncate 245.8 ns 275 ns -10.61%
256 KiB * 1k truncate 245.8 ns 275 ns -10.61%

@Xuanwo Xuanwo requested a review from PsiACE November 14, 2024 08:40
@Xuanwo Xuanwo merged commit 4dc0f15 into main Nov 14, 2024
274 checks passed
@Xuanwo Xuanwo deleted the polish-if-not-exsts branch November 14, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants