Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add default vscode config for more friendly developer experience #5331

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented Nov 16, 2024

For now, our project structure is not similar with default rust project.

The developer need to extra config the rust-analyzer before they start to write the code.

I would like to make the config right out of the box

Signed-off-by: Manjusaka <me@manjusaka.me>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not using vscode now, wait for other vscode users to take a review.

@@ -1,5 +1,4 @@
# IDE and editor
.vscode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the .vscode folder contain other files? Do we only need to include .vscode/settings.json?

Signed-off-by: Manjusaka <me@manjusaka.me>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Zheaoli for this!

@Xuanwo Xuanwo merged commit 1ca1b63 into main Dec 10, 2024
12 checks passed
@Xuanwo Xuanwo deleted the manjusaka/add-vscode-config branch December 10, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants