Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bindings/python): add python 3.10 back and remove pypy #5347

Merged
merged 11 commits into from
Nov 20, 2024

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Nov 19, 2024

Which issue does this PR close?

#5335

Closes #5335

Rationale for this change

build cp310 wheel with non-abi3 flags

What changes are included in this PR?

Are there any user-facing changes?

no

@trim21 trim21 force-pushed the cp310 branch 3 times, most recently from 3ea5e9f to 1ed0c8e Compare November 19, 2024 22:13
@trim21 trim21 marked this pull request as ready for review November 20, 2024 00:02
@trim21 trim21 marked this pull request as draft November 20, 2024 00:07
@trim21 trim21 marked this pull request as ready for review November 20, 2024 01:19
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trim21 for this change, mostly LGTM, only some minor changes.

bindings/python/Cargo.toml Outdated Show resolved Hide resolved
@@ -150,6 +150,8 @@ services-upyun = ["opendal/services-upyun"]
services-vercel-artifacts = ["opendal/services-vercel-artifacts"]
services-yandex-disk = ["opendal/services-yandex-disk"]

abi3 = ["pyo3/abi3-py311"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment on what this feature control and why we need this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Xuanwo Xuanwo changed the title build: add py310 back build(bindings/python): add python 3.10 back and remove pypy Nov 20, 2024
Co-authored-by: Xuanwo <github@xuanwo.io>
bindings/python/Cargo.toml Outdated Show resolved Hide resolved
bindings/python/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trim21 to add this!

@Xuanwo Xuanwo merged commit fc8f559 into apache:main Nov 20, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants