Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add setup action for hadoop to avoid build failures #5353

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

meteorgan
Copy link
Contributor

Which issue does this PR close?

None

Rationale for this change

The CI often fails because it cannot download hadoop-3.3.5, like this: https://github.com/apache/opendal/actions/runs/11973321010/job/33382084490?pr=5352

What changes are included in this PR?

Are there any user-facing changes?

No

@meteorgan meteorgan marked this pull request as draft November 22, 2024 15:25
@meteorgan meteorgan changed the title chore: cache hadoop-3.3.5 to avoid build failures chore: add setup action for hadoop to avoid build failures Nov 23, 2024
with:
distribution: temurin
java-version: "11"
- name: Setup hadoop env
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think adding a separate action only complicates things further. How about using the cache exclusively for hadoop-3.3.5.tar.gz here? Here is no other place uses this action.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every action related with hdfs may require this action. They all require setting up Java and a Hadoop environment.

@meteorgan meteorgan marked this pull request as ready for review November 24, 2024 10:33
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @meteorgan for for this!

@Xuanwo Xuanwo merged commit 4444330 into apache:main Nov 25, 2024
17 checks passed
@meteorgan meteorgan deleted the cache-hadoop branch December 3, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants