fix: update document against target format check and add hints #5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Xuanwo
reviewed
Nov 27, 2024
| fleet.png | ||
| update-ecs-loadbalancer.json | ||
| ``` | ||
|
|
||
| ### Example: use `oli` copy file from S3 to R2 | ||
|
|
||
| ```text | ||
| $ oli cp s3://fleet.png r2://fleet.png | ||
| $ oli ls r2:// | ||
| $ oli cp s3:/fleet.png r2:/fleet.png |
There was a problem hiding this comment.
Oh, I convinced myself this is by design 🙈
| @@ -147,7 +147,7 @@ impl Config { | |||
|
|
|||
| let location = Url::parse(s)?; | |||
| if location.has_host() { | |||
| Err(anyhow!("Host part in a location is not supported."))?; | |||
| Err(anyhow!("Host part in a location is not supported. Hint: are you typing `://` instead of `:/`?"))?; | |||
There was a problem hiding this comment.
Seems we are parsing the url in wrong.
Xuanwo
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The document about
oli's usage is misleadingWhat changes are included in this PR?
Are there any user-facing changes?
Yes, some text