Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrations/cloud_filter): use explicit stat instead of Entry::metadata in fetch_placeholders #5416

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

ho-229
Copy link
Contributor

@ho-229 ho-229 commented Dec 15, 2024

Rationale for this change

The Operator::lister will not fetch Metadata::content_length implicitly, and the zero Metadata::content_length causes CloudFiler::fetch_data won't be called.

Related #5414

What changes are included in this PR?

Call Operator:stat explicitly in CloudFiler::fetch_placeholders.

@Xuanwo
Copy link
Member

Xuanwo commented Dec 15, 2024

Thank you @ho-229 for the fix. The only thing left is the failing clippy check: https://github.com/apache/opendal/actions/runs/12337198169/job/34430608724?pr=5416

Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zheaoli Zheaoli merged commit 2ec0aff into apache:main Dec 15, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants