Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): Add config parse and generate support #5454

Merged
merged 3 commits into from
Dec 25, 2024
Merged

feat(dev): Add config parse and generate support #5454

merged 3 commits into from
Dec 25, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 25, 2024

Which issue does this PR close?

Inspired by #5451 from @trim21 and @Zheaoli's suggestion.

Rationale for this change

Parse config from rust code so that other bindings can generate nice public API.

What changes are included in this PR?

The ASF parser for rust core services config.

Are there any user-facing changes?

No, dev only.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 25, 2024

Also cc @trim21 to take a look. I left the python part empty for you.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will follow up the Python binding generate part after this PR is been merged

@Xuanwo Xuanwo merged commit 22d2cef into main Dec 25, 2024
12 checks passed
@Xuanwo Xuanwo deleted the config-parser branch December 25, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants