OPENNLP-1627 - Add new models from ud 1.1 familiy #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
approved these changes
Oct 15, 2024
|
Wow, This looks thorough! Great work ! <3 |
atarora
approved these changes
Oct 15, 2024
mawiesne
changed the title
mawiesne
approved these changes
Oct 17, 2024
|
@rzo1 What do you make from README.md => "Ensure to add a new model to the expected-models.txt file located in opennlp-models-test." Shouldn't this be included/change with this PR also? |
|
It is changed but GH doesn't show it in the web view, cf. 037cec7#diff-85b66f71480e436210ee3c949738f0ad822ceb95e38b851866d463a90525e137 |
Ic, well this seems to be just fine then. |
mawiesne
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote some local glue code to auto generate those new models because I didn't like to do copy paste...
So here it is ...