OPENNLP-1548 - Cleanup handling of output streams in cmdline tools

apache · Nov 3, 2024 · e533feb · e533feb
1 parent b473d08
commit e533feb
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatCrossValidatorTool.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatCrossValidatorTool.java
@@ -119,7 +119,7 @@ public void run(String format, String[] args) {
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do

diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatEvaluatorTool.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatEvaluatorTool.java
@@ -136,7 +136,7 @@ public void close() throws IOException {
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do

diff --git a/...ls/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorCrossValidatorTool.java b/...ls/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorCrossValidatorTool.java
@@ -115,7 +115,7 @@ public void run(String format, String[] args) {
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do

diff --git a/...p-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorEvaluatorTool.java b/...p-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorEvaluatorTool.java
@@ -136,7 +136,7 @@ public void close() throws IOException {
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do

diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmatizerEvaluatorTool.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmatizerEvaluatorTool.java
@@ -110,7 +110,7 @@ public void run(String format, String[] args) {
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do

diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerCrossValidatorTool.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerCrossValidatorTool.java
@@ -121,7 +121,7 @@ public void run(String format, String[] args) {
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do

diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerEvaluatorTool.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerEvaluatorTool.java
@@ -115,7 +115,7 @@ public void run(String format, String[] args) {
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do