Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1599 - Add "model.language" to opennlp-models #641

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jul 24, 2024

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

see apache/opennlp-models#9

Rational is to avoid something like

 try {
                final ClassPathModelLoader loader = new ClassPathModelLoader();
                final Set<ClassPathModelEntry> models = new ClassgraphModelFinder().findModels(false);

                for (ClassPathModelEntry entry : models) {
                    final ClassPathModel model = loader.load(entry);
                    if (model.getModelName().contains(element.getLang())) {
                        final TokenizerME tokenizer = new TokenizerME(new TokenizerModel(new ByteArrayInputStream(model.model())));
                        tokenizers.put(element.getLang(), tokenizer);
                        return tokenizer;
                    }
                }
            } catch (IOException e) {
                throw new PipelineExecutionException(e);
            }

and just directly use model.getModelLanguage() (from a user perspective because the model's name might not actually contain the actual language the model was trained for).

@rzo1 rzo1 requested review from kinow, jzonthemtn and mawiesne July 24, 2024 13:43
@rzo1 rzo1 self-assigned this Jul 24, 2024
@rzo1 rzo1 force-pushed the OPENNLP-1599-Add-model.language-to-opennlp-models branch from 17f9297 to 282eb0c Compare July 24, 2024 13:46
@mawiesne mawiesne marked this pull request as draft August 7, 2024 07:36
@rzo1 rzo1 force-pushed the OPENNLP-1599-Add-model.language-to-opennlp-models branch from 282eb0c to e5a8630 Compare August 7, 2024 18:31
@rzo1 rzo1 marked this pull request as ready for review August 7, 2024 18:32
@rzo1 rzo1 merged commit 066315f into main Aug 7, 2024
10 checks passed
@mawiesne mawiesne deleted the OPENNLP-1599-Add-model.language-to-opennlp-models branch August 7, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants