Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1687: Remove quotes around $HEAP in opennlp tools shell script #734

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Dec 27, 2024

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.


Previously, $HEAP was wrapped in quotes when passed to java, causing an empty or incorrect argument to be parsed, which could trigger a “Could not find or load main class” error (e.g., in Homebrew environments). By removing the quotes, $HEAP is now passed correctly, ensuring Java recognizes the classpath and preventing the ClassNotFoundException. This also allows multiple or custom JVM arguments (e.g., -Xmx512m -Xms256m) to be supplied through $JAVA_HEAP if desired.

relates to Homebrew/homebrew-core#202547

…ss` error

Signed-off-by: Rui Chen <rui@chenrui.dev>
@mawiesne mawiesne changed the title fix: remove quote for $HEAP to fix Could not find or load main class error OPENNLP-1687: Remove quote for $HEAP in the launch scripts Jan 5, 2025
@mawiesne mawiesne self-requested a review January 5, 2025 05:09
@mawiesne mawiesne self-assigned this Jan 5, 2025
@mawiesne mawiesne changed the title OPENNLP-1687: Remove quote for $HEAP in the launch scripts OPENNLP-1687: Remove quote for $HEAP in opennlp launcher shell script Jan 5, 2025
@mawiesne mawiesne changed the title OPENNLP-1687: Remove quote for $HEAP in opennlp launcher shell script OPENNLP-1687: Remove quote for $HEAP in opennlp tools shell script Jan 5, 2025
@mawiesne
Copy link
Contributor

mawiesne commented Jan 5, 2025

@chenrui333 Thx for finding this and providing a PR.

@mawiesne mawiesne changed the title OPENNLP-1687: Remove quote for $HEAP in opennlp tools shell script OPENNLP-1687: Remove quotes for $HEAP in opennlp tools shell script Jan 5, 2025
@mawiesne mawiesne changed the title OPENNLP-1687: Remove quotes for $HEAP in opennlp tools shell script OPENNLP-1687: Remove quotes around $HEAP in opennlp tools shell script Jan 5, 2025
@mawiesne mawiesne merged commit a81c162 into apache:main Jan 5, 2025
7 checks passed
@chenrui333 chenrui333 deleted the fix-build branch January 10, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants