Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1719: Add additional ITs for verification of UD POS models #757

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Mar 23, 2025

Change

  • adds POSTaggerMEIT with sample sentences for:
    • CA, as provided by @kinow
    • DE, as found in original UD material
    • EN, as found in OpenNLP dev-manual
    • PT, as found in original UD material
    • PL => 3 tagged sentences in Polish language, tagged and community provided by: @alsmolarczyk, native speaker

Checks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

Sorry, something went wrong.

@mawiesne mawiesne added the java Pull requests that update Java code label Mar 23, 2025
@mawiesne mawiesne self-assigned this Mar 23, 2025
@mawiesne mawiesne force-pushed the OPENNLP-1719-Add-additional-ITs-for-verification-of-UD-POS-models branch from 52b7ee1 to 21c4c7d Compare March 23, 2025 20:43
@mawiesne mawiesne requested review from kinow and rzo1 March 23, 2025 20:44
@mawiesne
Copy link
Contributor Author

mawiesne commented Mar 23, 2025

Welcome 👋 and thx @alsmolarczyk for providing your input. I used it as a reference for the Polish language. 1 of 3 examples was tagged perfectly, 1 fits with small adjustments, and 1 requires your feedback.

Please check line 128 of POSTaggerMEIT in the PR branch. What do you make of the tagging result:

Więzienie_NOUN nie_PART tkwi_VERB na_ADP zewnątrz_ADV ,_PUNCT
ale_CCONJ jest_VERB w_ADP środku_NOUN każdego_DET z_ADP nas_PRON ._PUNCT

You tagged it as:

Więzienie_NOUN nie_PART tkwi_VERB na_ADP zewnątrz_NOUN ,_PUNCT
ale_CCONJ jest_VERB w_ADP środku_NOUN każdego_PRON z_ADP nas_PRON ._PUNCT

I've left a TODO for now, until we've heard your feedback.

Verified

This commit was signed with the committer’s verified signature.
ernestognw Ernesto García
- EN (dev-manual)
- CA (by @kinow)
- DE (ud data)
- PT (ud data)
@mawiesne mawiesne force-pushed the OPENNLP-1719-Add-additional-ITs-for-verification-of-UD-POS-models branch from 21c4c7d to 235f503 Compare March 23, 2025 20:55
@mawiesne mawiesne requested a review from jzonthemtn March 23, 2025 20:58
@alsmolarczyk
Copy link

Welcome 👋 and thx @alsmolarczyk for providing your input. I used it as a reference for the Polish language. 1 of 3 examples was tagged perfectly, 1 fits with small adjustments, and 1 requires your feedback.

Please check line 128 of POSTaggerMEIT in the PR branch. What do you make of the tagging result:

Więzienie_NOUN nie_PART tkwi_VERB na_ADP zewnątrz_ADV ,_PUNCT
ale_CCONJ jest_VERB w_ADP środku_NOUN każdego_DET z_ADP nas_PRON ._PUNCT

You tagged it as:

Więzienie_NOUN nie_PART tkwi_VERB na_ADP zewnątrz_NOUN ,_PUNCT
ale_CCONJ jest_VERB w_ADP środku_NOUN każdego_PRON z_ADP nas_PRON ._PUNCT

I've left a TODO for now, until we've heard your feedback.

Hello @mawiesne,
Thanks for taking a look! After reviewing the tagging result, I can confirm that it is correct.

Verified

This commit was signed with the committer’s verified signature.
ernestognw Ernesto García
…munity provided by: @alsmolarczyk, a native speaker of the Polish language

- adjusts tests assumption for 1 PL example after clearance via @alsmolarczyk, see PR discussion
@mawiesne mawiesne force-pushed the OPENNLP-1719-Add-additional-ITs-for-verification-of-UD-POS-models branch from 235f503 to 9772ea2 Compare March 31, 2025 10:22
@mawiesne mawiesne marked this pull request as ready for review March 31, 2025 10:22
@mawiesne
Copy link
Contributor Author

@alsmolarczyk Thx for the feedback. I've resolved the remaining TODO and update the PR to be ready for merge. Please feel free to approve the PR from your side as well.

FYI: @kinow / @jzonthemtn

@mawiesne mawiesne merged commit 27cfdf6 into main Apr 3, 2025
10 checks passed
@mawiesne mawiesne deleted the OPENNLP-1719-Add-additional-ITs-for-verification-of-UD-POS-models branch April 3, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants