-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uodated two strings "temporally" to "temporarily" #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[:space:] should represent any whitespace character in regular expressions. However, in the older, before OOo 3.4, it did not find the tab \t. Used to be Issue 41706 Now it does due to changing the regexp engine since 3.4
… May, 1 2019 Added the start date for the era Reiwa to the variable "static Era gengou_eraArray[ ]" Updated after post on the forum https://forum.openoffice.org/en/forum/viewtopic.php?f=9&t=104665
Just noticed the occurrence of the string "OpenOffice.org New Thesaurus" in the dialog Writing Aids (Tools > Options > Language Settings > Writing Aids) in the Developer Build 4.2.0 This should probably be changed to "New Thesaurus" only. OpenGrok found the string just once, in: /trunk/main/lingucomponent/source/thesaurus/libnth/nthesimp.cxx (revision c4c42a0) Line: 576 { 577 MutexGuard aGuard( GetLinguMutex() ); 578 return A2OU( "OpenOffice.org New Thesaurus" ); 579 } Since I'm no developer at all I won't touch the code. Hope someone will pick this up. Should probably also need to be changed in branches AOO41 and AOO42 too Earlier reported in BugZilla Issue ID: 128483 https://bz.apache.org/ooo/show_bug.cgi?id=128483
Occurence "OpenOffice.org" in dialog Writing Aids for new thesaurus
Replaced temporally by temporarily. The latter seems to be the most appropriate word to use. As to me, it seems that the definitions below that sentence are disabled for now
Replaced temporally by temporarily, as that seems to be the most suitable word to use. I read it as: "If the condition no longer fails on RH9, it will probably be reinstated."
I would have hoped that somebody else shows interest in merging PR, but OK... |
asfgit
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Create .gitattributes * Delete .gitattributes * Create .gitattributes * Delete .gitattributes * Updated download link for zlib, updated LICENSE * Fixed typo (minmal -> minimal) * Changed icon for OLE objects in Navigation (Writer) - This fixes issue 128315 * Fixed typos * Latest Finnish translation, contributed by: Mechtilde * Changed icon for OLE objects in Navigation (Writer) - Forgot icons in Classic * Create .gitattributes * Delete .gitattributes * Create .gitattributes * Delete .gitattributes * Added new file * Fixed typos * Changed helptext after resolved problem. [:space:] should represent any whitespace character in regular expressions. However, in the older, before OOo 3.4, it did not find the tab \t. Used to be Issue 41706 Now it does due to changing the regexp engine since 3.4 * Updated variable static Era gengou_eraArrya with new era Reiwa, as of May, 1 2019 Added the start date for the era Reiwa to the variable "static Era gengou_eraArray[ ]" Updated after post on the forum https://forum.openoffice.org/en/forum/viewtopic.php?f=9&t=104665 * Occurence "OpenOffice.org" in dialog Writing Aids for new thesaurus Just noticed the occurrence of the string "OpenOffice.org New Thesaurus" in the dialog Writing Aids (Tools > Options > Language Settings > Writing Aids) in the Developer Build 4.2.0 This should probably be changed to "New Thesaurus" only. OpenGrok found the string just once, in: /trunk/main/lingucomponent/source/thesaurus/libnth/nthesimp.cxx (revision c4c42a0) Line: 576 { 577 MutexGuard aGuard( GetLinguMutex() ); 578 return A2OU( "OpenOffice.org New Thesaurus" ); 579 } Since I'm no developer at all I won't touch the code. Hope someone will pick this up. Should probably also need to be changed in branches AOO41 and AOO42 too Earlier reported in BugZilla Issue ID: 128483 https://bz.apache.org/ooo/show_bug.cgi?id=128483 * Update libs2test.txt = temporally > temporarily Replaced temporally by temporarily. The latter seems to be the most appropriate word to use. As to me, it seems that the definitions below that sentence are disabled for now * Update osl_File.cxx temporally > temporarily Replaced temporally by temporarily, as that seems to be the most suitable word to use. I read it as: "If the condition no longer fails on RH9, it will probably be reinstated." --------- Co-authored-by: mseidel <mseidel@apache.org> (cherry picked from commit 0a01f5a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to me "temporarily" is the more suitable word to use.
ec2a213
b2701ed