Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize XxHash64.apply method #125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize XxHash64.apply method #125

wants to merge 1 commit into from

Conversation

abdelhak-zaaim
Copy link

@abdelhak-zaaim abdelhak-zaaim commented Nov 4, 2024 •
edited
Loading

Optimize XxHash64.apply method.

  • Refactored the XxHash64.apply method to reduce code duplication and improve readability.
  • Introduced helper methods for processing chunks and finalizing the hash.

@abdelhak-zaaim abdelhak-zaaim changed the title Optimize XxHash64.apply method and add performance benchmarks Optimize XxHash64.apply method Nov 4, 2024
@rmannibucau
Copy link
Contributor

@abdelhak-zaaim what did you mean by "optimize", remove duplication only? This looks like it will use less the vectorization on processors so it could be slower at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdelhak-zaaim @rmannibucau