Fix invalid warning message #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdeuser, can you review? |
|
@dubee - is there a pg for this? |
mdeuser
reviewed
May 23, 2018
| return errResp.Response.Success | ||
| } | ||
| Debug(DbgWarn, "IsResponseResultSuccess: failed to parse response result: %v\n", err) | ||
|
|
There was a problem hiding this comment.
let's see... the affected method is only looking for a whisk response (i.e. correct unmarshalled json with a "result" object).. the warning message is provided when that condition is not met. so maybe at this spot the message should be
Debug(DbgWarn, "IsResponseResultSuccess: http response did not contain a 'response' field; assuming successful response\n") ???
houshengbo
approved these changes
Nov 16, 2018
This was referenced Nov 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsResponseResultSuccess()inaccurately generates a debug message indicating a failure.Closes #89