Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 7.3 runtime to the docker-compose manifest #188

Merged
merged 3 commits into from
Dec 17, 2018
Merged

Add PHP 7.3 runtime to the docker-compose manifest #188

merged 3 commits into from
Dec 17, 2018

Conversation

akrabat
Copy link
Member

@akrabat akrabat commented Dec 16, 2018

Add support for the new PHP 7.3 runtime as per apache/openwhisk#4174

rabbah
rabbah reviewed Dec 16, 2018
View reviewed changes
Copy link
Member

@rabbah rabbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to unset php 7.2 as default

csantanapr
csantanapr approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
minor nit, need to add image to Makefile for docker-pull-full

@akrabat
Copy link
Member Author

akrabat commented Dec 17, 2018 •
edited
Loading

minor nit, need to add image to Makefile for docker-pull-full

Done.

@csantanapr csantanapr mentioned this pull request Dec 17, 2018
Closed
@csantanapr csantanapr merged commit 48370d6 into apache:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabbah rabbah rabbah left review comments

@csantanapr csantanapr csantanapr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akrabat @csantanapr @rabbah