Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable setting user-supplied auth tokens on API create via require-whisk-auth annotation #1083

Merged
merged 46 commits into from
Jan 24, 2020
Merged

Enable setting user-supplied auth tokens on API create via require-whisk-auth annotation #1083

merged 46 commits into from
Jan 24, 2020

Conversation

mrutkows
Copy link
Contributor

@mrutkows mrutkows commented Jan 8, 2020

No description provided.

@mrutkows
Fix schema for web-secure and support auth annotations
82a3824
@mrutkows
Fix schema for web-secure and support auth annotations
ff7869a
@mrutkows
Fix schema for web-secure and support auth annotations
07e131e
@mrutkows
Fix schema for web-secure and support auth annotations
13e1b4e
@mrutkows
Fix schema for web-secure and support auth annotations
26276e5
@mrutkows
Fix schema for web-secure and support auth annotations
2033ecf
@mrutkows
Fix schema for web-secure and support auth annotations
05e93de
@mrutkows
Fix schema for web-secure and support auth annotations
3638ae3
@mrutkows
Fix schema for web-secure and support auth annotations
c29f32c
@mrutkows
Fix schema for web-secure and support auth annotations
8d11a99
@mrutkows
Fix schema for web-secure and support auth annotations
4d624a8
@mrutkows
Fix schema for web-secure and support auth annotations
ca4faa4
@mrutkows
Fix schema for web-secure and support auth annotations
5d28d58
@mrutkows
Fix schema for web-secure and support auth annotations
612423b
@mrutkows
Fix schema for web-secure and support auth annotations
14708ac
@mrutkows
Fix schema for web-secure and support auth annotations
adf51b6
@mrutkows
Fix schema for web-secure and support auth annotations
394e728
@mrutkows
Fix schema for web-secure and support auth annotations
cb919d2
@mrutkows
Move validation/error logic to parser phase
b668191
@mrutkows
Move validation/error logic to parser phase
e312574
@mrutkows
Account for boolean values
93e7add
@mrutkows
rewrite require-auth validation logic to be more type aware and effic…
bdca899 
…ient
@mrutkows
Add unit test for diff data types of require-whisk-auth values
1d26523
@mrutkows
Add unique int. tests for require whisk auth
642b81c
@mrutkows
Add unique int. tests for require whisk auth
d0bd5a0
@mrutkows
Add unique int. tests for require whisk auth
b7fdfd7
@mrutkows
Add unique int. tests for require whisk auth
487f0f5
@mrutkows
clean up TODOs and valid auth int. testcase
457b755
@mrutkows
clean up TODOs and valid auth int. testcase
5bf6414
@mrutkows
clean up TODOs and valid auth int. testcase
42918e6
@mrutkows
Add integration tests for invalid values
352b2f8
@mrutkows
Update docs and comments in code
e4fdb55
@mrutkows
Update docs and comments in code
ff39d29
@mrutkows
Update docs and comments in code
00827fa
@mrutkows
Update docs and comments in code
29e56ad
@mrutkows
remove timing error prone managed deplyment tests
2816a24
@mrutkows
Clean up functional tests and actually create APIs for valid tests
0e19ece
@mrutkows
Update supported runtimes table; add image links
a77fc79
@mrutkows mrutkows marked this pull request as ready for review January 24, 2020 20:13
@mrutkows
Copy link
Contributor Author

Fixes #1046

pritidesai
pritidesai approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @mrutkows for additional refactoring!

@mrutkows mrutkows changed the title Fix schema for web-secure and support auth annotations Enable setting user-supplied auth tokens on API create via require-whisk-auth annotation Jan 24, 2020
@mrutkows mrutkows mentioned this pull request Jan 24, 2020
Closed
@pritidesai pritidesai merged commit 0a6491c into apache:master Jan 24, 2020
@mrutkows mrutkows deleted the annotations branch January 25, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai approved these changes

Assignees
No one assigned
Labels
documentation enhancement priority: high specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrutkows @pritidesai