Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.34 support #1119

Merged
merged 7 commits into from
Feb 22, 2021
Merged

Rust 1.34 support #1119

merged 7 commits into from
Feb 22, 2021

Conversation

kingledion
Copy link
Contributor

Adding support for kind "rust:1.34" in wskdeploy.

This is tested working in local deployments with cargo and source files zipped, but is not working with plain '.rs' extension files.

@mrutkows
Copy link
Contributor

@kingledion Thanks for your contribution! It is quite a good coincidence as I had intended to figure out how to bring in the Rust tests from this old PR #1074.

Effectively this PR:
Fixes #1074

If there are still mapping issues in the util. from seeing a .rs extension to the actual runtime; can we open an issue and track/debug/work on as a follow-on? Thanks!

Copy link
Contributor

@mrutkows mrutkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work filling out the intrinsic support for the Rust runtime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants