Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update openwhisk-client-go to release 1.1.0 as well as other pkg dependencies #1124

Merged
merged 8 commits into from
Mar 5, 2021
Merged

Update openwhisk-client-go to release 1.1.0 as well as other pkg dependencies #1124

merged 8 commits into from
Mar 5, 2021

Conversation

mrutkows
Copy link
Contributor

@mrutkows mrutkows commented Mar 3, 2021

No description provided.

@mrutkows mrutkows added the build label Mar 3, 2021
@mrutkows mrutkows self-assigned this Mar 3, 2021
@mrutkows mrutkows mentioned this pull request Mar 4, 2021
Open
@mrutkows
Copy link
Contributor Author

mrutkows commented Mar 4, 2021 •
edited
Loading

Please note that after this PR is merged the only pks that wskdeploy relies upon that are not based on a release (tag) are as the following:

  • github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32

which is the latest commit available and includes its own upgrade to gomod, and

  • github.com/cloudfoundry/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21

which has had not had any commits since Nov 2015 and never produced any releases or tags... ideally, we would look to replace this very small function (i.e., DetectLocale()) used to detect current system language

@mrutkows mrutkows marked this pull request as ready for review March 5, 2021 21:20
pritidesai
pritidesai approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, lot of cleanup, thanks @mrutkows

@mrutkows mrutkows merged commit f4f94e7 into apache:master Mar 5, 2021
@mrutkows mrutkows deleted the updatelibs branch March 5, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrove-oss dgrove-oss dgrove-oss approved these changes

@pritidesai pritidesai pritidesai approved these changes

Assignees

@mrutkows mrutkows

Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrutkows @pritidesai @dgrove-oss