chore: fix spelling #1127
chore: fix spelling #1127
Conversation
There was a problem hiding this comment.
Would love to merge this, but the go-binadata tool needs to be run against the translated string changes in the files following these instructions: https://github.com/apache/openwhisk-wskdeploy/blob/master/wski18n/README.md
| @@ -95,7 +95,7 @@ func testLoadAndBindDeploymentYAML(t *testing.T, path string, triggerName string | |||
| dReader := NewDeploymentReader(sDeployer) | |||
| err := dReader.HandleYaml() | |||
|
|
|||
| // DEBUG() Uncomment to display initial DeploymentDescriptor (manifest, deployemnt befopre binding) | |||
There was a problem hiding this comment.
Always type this wrong ;) Thx
|
|
||
| When you want to return an error, you need to provide the same structure wrapped into an `error` object. If you don't wrap it into an `error` object, it will still work from an HTTP prespective but OpenWhisk will not recognise it as an error. |
There was a problem hiding this comment.
Another typo common to me...
| @@ -31,8 +31,8 @@ import ( | |||
| const PATH_WILDCARD = "*" | |||
| const ONE_DIR_UP = "../" | |||
|
|
|||
| func NewZipWritter(src string, des string, include [][]string, exclude []string, manifestFilePath string) *ZipWritter { | |||
There was a problem hiding this comment.
This has long bothered me; thanks for fixing and cascading
| @@ -21,7 +21,7 @@ | |||
| }, | |||
| { | |||
| "id": "msg_cmd_desc_long_root", | |||
| "translation": "The OpenWhisk Deployment Tool\n\nTo begin working with wskdeploy, run the 'wskdeploy' command:\n\n\t$ wskdeploy\n\nThis will deploy OpenWhisk assets specified in manifest.yaml or manifest.yml\nIf current directory doesnt have any manifest file, wskdeploy prints this help message.\n\nThe most common ways of using wskdeploy to deploy and/or undeploy OpenWhisk assets are:\n\n$ wskdeploy\n$ wskdeploy -m path/to/manifest.yaml\n$ wskdeploy -m path/to/manifest.yaml -d path/to/deployment.yaml\n$ wskdeploy undeploy\n$ wskdeploy undeploy -m path/to/manifest.yaml\n$ wskdeploy undeploy -m path/to/manifest.yaml -d path/to/deployment.yaml\n\nAunthentication:\nwskdeploy reads credentials from $HOME/.wskprops by default\nOverwrite default config file on CLI:\n $ wskdeploy --config <config file> -m path/to/manifest.yaml\nOr specify all three on CLI:\n $ wskdeploy --apihost HOST --auth KEY --namespace NAMESPACE -m path/to/manifest.yaml" | |||
There was a problem hiding this comment.
These changes need to be "built" using the go-bindata tool to render them as ascii-encoded data using the following instructions: https://github.com/apache/openwhisk-wskdeploy/blob/master/wski18n/README.md
|
@jbampton Thanks for such a comprehensive cleanup of all our code/docs! If you could run the go-bindata tool as ref. in the review (https://github.com/apache/openwhisk-wskdeploy/blob/master/wski18n/README.md) and commit the resultant |
No description provided.