Skip to content

Conversation

@markusthoemmes
Copy link
Contributor

Was searching for a bug and cleaned up a little meanwhile... No change in behavior intended.

@markusthoemmes markusthoemmes added the review Review for this PR has been requested and yet needs to be done. label Jul 11, 2018
@markusthoemmes markusthoemmes requested a review from rabbah July 11, 2018 13:12
@codecov-io
Copy link

codecov-io commented Jul 11, 2018

Codecov Report

Merging #3870 into master will decrease coverage by 0.01%.
The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3870      +/-   ##
==========================================
- Coverage   74.46%   74.45%   -0.02%     
==========================================
  Files         138      137       -1     
  Lines        6478     6471       -7     
  Branches      409      408       -1     
==========================================
- Hits         4824     4818       -6     
+ Misses       1654     1653       -1
Impacted Files Coverage Δ
.../scala/whisk/core/database/CouchDbRestClient.scala 87.23% <100%> (ø) ⬆️
.../src/main/scala/whisk/http/PoolingRestClient.scala 89.28% <80%> (-1.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50de78a...d9f2343. Read the comment docs.

Copy link
Member

@dubee dubee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PG2 3365 ⏳

@rabbah rabbah requested review from chetanmeh and removed request for rabbah July 11, 2018 15:35
@rabbah
Copy link
Member

rabbah commented Jul 11, 2018

LGTM.

Copy link
Member

@dubee dubee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PG2 3365 🔵

@dubee dubee merged commit 4a0b4cd into apache:master Jul 11, 2018
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review Review for this PR has been requested and yet needs to be done.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants