-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for switch to Scala 2.12.7 #4074
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires Scala 2.12
Requires Scala 2.12
Codecov Report
@@ Coverage Diff @@
## master #4074 +/- ##
==========================================
- Coverage 86% 81.05% -4.95%
==========================================
Files 147 147
Lines 7180 7180
Branches 445 439 -6
==========================================
- Hits 6175 5820 -355
- Misses 1005 1360 +355
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements the #4062. It makes required code changes which also work with Scala 2.11. This can be committed sooner and would reduce any rework to be done in case it takes time to merge #4062.
This is specially important to minimize rework due to #4073. So even if #4073 get merged before Switch to Scala 2.12 it would be easier to do required leftover changes for #4062
Description
Related issue and scope
My changes affect the following components
Types of changes
Checklist: