changes to include gloang runtime #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csantanapr
requested changes
Oct 31, 2018
ansible/files/runtimes.json
Outdated
| @@ -208,6 +208,22 @@ | |||
| } | |||
| ] | |||
| }, | |||
| "golang": [ | |||
There was a problem hiding this comment.
this needs to be go instead
Suggested change
| "golang": [ | |
| "go": [ |
ansible/files/runtimes.json
Outdated
| @@ -208,6 +208,22 @@ | |||
| } | |||
| ] | |||
| }, | |||
| "golang": [ | |||
| { | |||
| "kind": "golang:1.11", | |||
There was a problem hiding this comment.
this needs to use go
Suggested change
| "kind": "golang:1.11", | |
| "kind": "go:1.11", |
csantanapr
approved these changes
Oct 31, 2018
|
Give me a chance to read the docs please 🙏🏼 |
csantanapr
reviewed
Oct 31, 2018
|
We should use another word for “rule” when we want to reference an api/interface “contract” or “convention” |
|
weird that Travis is failing on systems tests unrelated to go 😱 |
|
@sciabarracom the systems tests pass in your local computer with the go changes? |
Codecov Report
@@ Coverage Diff @@
## master #4093 +/- ##
==========================================
- Coverage 86.12% 80.96% -5.16%
==========================================
Files 148 148
Lines 7249 7249
Branches 445 445
==========================================
- Hits 6243 5869 -374
- Misses 1006 1380 +374
Continue to review full report at Codecov.
|
|
@rabbah your had a chance to review the docs? |
rabbah
reviewed
Nov 2, 2018
docs/actions-go.md
Outdated
|
|
||
| # Creating and Invoking Go Actions | ||
|
|
||
| The runtime `actionloop-golang-v1.11` runtime can execute actions written in the Go programming language in OpenWhisk, either as precompiled binary or compiling sources on the fly. |
docs/actions-go.md
Outdated
|
|
||
| ## Entry Point | ||
|
|
||
| The source code of an action is one or more Go source file. The entry point of the action is a function, placed in the `main` package. The default name for the main function is `Main`, but you can change it to any name you want using the `--main` switch in `wsk`. The name is however always capitalized. The function must have a specific signature, as described next. |
|
|
||
| The runtime `actionloop-golang-v1.11` accepts: | ||
|
|
||
| - executable binaries in Linux ELF executable compiled for the AMD64 architecture |
docs/actions-go.md
Outdated
|
|
||
| - executable binaries in Linux ELF executable compiled for the AMD64 architecture | ||
| - zip files containing a binary executable named `exec` at the top level, again a Linux ELF executable compiled for the AMD64 architecture | ||
| - a single file source code in Go language, that will be compiled |
There was a problem hiding this comment.
A single source file in Go, that will be compiled
docs/actions-go.md
Outdated
| For running tests, editing without errors with package resolution, you need to use a `src` folder, place the sources that belongs to the main package in the `src` and place sources of your package in the `src/hello` folder. | ||
|
|
||
| You should import it your subpackage with `import "hello"`. | ||
| Note this means if you want to compile locally you have to set your `GOPATH` to parent directory of your `src` directory. If you use VSCode, you need to enable the `go.inferGopath` option. |
docs/actions-go.md
Outdated
| cd src | ||
| zip -r ../hello.zip * | ||
| cd .. | ||
| wsk action create hello2-go hello.zip --kind go:1.11 |
There was a problem hiding this comment.
I think the action names can just be hello to avoid the unnecessary hyphe. Easier to read. Maybe instead of hello2 it’s hellozip
docs/actions-go.md
Outdated
|
|
||
| Here a `Makefile` is helpful. Check the [examples](https://github.com/apache/incubator-openwhisk-runtime-go/tree/master/examples) for a collection of tested Makefiles. The generated executable is suitable to be deployed in OpenWhisk, so you can do: | ||
|
|
||
| `wsk action create my/action exec.zip --kind go:1.11` |
There was a problem hiding this comment.
my/action? This requires a package.
This was referenced Nov 2, 2018
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests and config to include the go runtime
Related issue and scope
My changes affect the following components
Types of changes
Checklist: